linux-kernel - Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 04 May 2018 11:40:58 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Connor McAdams" <conmanx360@...il.com>
Cc:     <alsa-devel@...a-project.org>,
        "Jérémy Lefaure" <jeremy.lefaure@....epita.fr>,
        "Jaroslav Kysela" <perex@...ex.cz>, <o-takashi@...amocchi.jp>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading

On Fri, 04 May 2018 06:19:44 +0200,
Connor McAdams wrote:
> 
> This patch adds PCI quirk ID's for the Sound Blaster Z and Recon3Di.
> Only the currently tested ID's have been added.
> 
> This patch also adds the ability to load alternative firmwares for each
> card, the firmwares can be obtained from within the Windows driver.
> The Recon3Di uses "ctefx-r3di.bin" and the Sound Blaster Z uses
> "ctefx-sbz.bin". If the alternative firmware for the given quirk is not
> found, the original ctefx.bin will be used. This has been confirmed to
> work for both the R3Di and the SBZ.
> 
> This patch also makes the character array *dirstr a const.
> 
> Signed-off-by: Connor McAdams <conmanx360@...il.com>

I reply here as the patch series lacks of a cover letter, as already
Sakamoto-san mentioned.

I like the patches in general.  It's a great effort for the long-time
PITA.  I already replied one minor thing I stumbled on.  But the whole
changes are specific to ca0132, so there is no big danger by the patch
series itself per se.

However, one thing to be fixed is the style you took in the series,
"put some changes commented out for the next patch".  I guess you made
it in that way for ease of splitting patches.  But of course it's
messy when you follow the patch history as a reader.

So please clean up them, move the new code to the new patch, and
resubmit as v3.  And, please give also a proper subject prefix and a
cover letter, too :)

Thanks!

Takashi