linux-kernel - Re: [PATCH 1/4] alim15x3: move irq-restore before pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 04 May 2018 13:37:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bigeasy@...utronix.de
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH 1/4] alim15x3: move irq-restore before pci_dev_put()

From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Date: Fri,  4 May 2018 16:24:43 +0200

> init_chipset_ali15x3() initializes the chipset during init with disabled
> interrupts. There is no need to keep the interrupts disabled during
> pci_dev_put().
> Move the irq-restore before pci_dev_put() is invoked.
> 
> Side note: The same init is performed in
> drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts.
> It looks that the same hardware is supported in the ATA land. Would it
> make sense to remove this driver since it is supported in the other
> subsystem?
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Acked-by: David S. Miller <davem@...emloft.net>