linux-kernel - Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 May 2018 02:10:58 +0300
From:   Stanimir Varbanov <svarbanov@...sol.com>
To:     Shawn Guo <shawn.guo@...aro.org>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     Yao Chen <chenyao11@...wei.com>, songxiaowei@...ilicon.com,
        wangbinghui@...ilicon.com, lorenzo.pieralisi@....com,
        bhelgaas@...gle.com, xuwei5@...ilicon.com, robh+dt@...nel.org,
        mark.rutland@....com, catalin.marinas@....com, will.deacon@....com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        dimitrysh@...gle.com, guodong.xu@...aro.org,
        Jianguo Sun <sunjianguo1@...wei.com>
Subject: Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

Hi,

On  9.05.2018 07:51, Shawn Guo wrote:
> Hi Bjorn,
> 
> On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote:
> ...
>>> +			return ret;
>>> +		}
>>> +	}
>>> +
>>> +	pci->pp.root_bus_nr = -1;
>>
>> Setting root_bus_nr looks like an unrelated change that should be in a
>> separate patch.
>>
>> But I'm not sure why you need to set root_bus_nr at all, since
>> dw_pcie_host_init() always sets it.
>>
>> Some other callers of dw_pcie_host_init() do set it:
>>
>>    exynos_add_pcie_port()
>>    imx6_add_pcie_port()
>>    armada8k_add_pcie_port()
>>    artpec6_add_pcie_port()
>>    dw_plat_add_pcie_port()
>>    histb_pcie_probe()
>>    qcom_pcie_probe()
>>    spear13xx_add_pcie_port()
>>
>> But I don't see *why* any of these need to set it.  If they don't need to
>> set it, they shouldn't.
> 
> Mostly it's a blind copy of unnecessary code.  I tested histb driver
> by dropping the line, and did not see anything broken.  I will cook up
> a series to remove the code from all above drivers, and copy
> corresponding driver owner to comment.
> 
>> And it would be nice if histb and qcom followed the structure and naming
>> conventions of the other drivers, i.e., they should have
>> histb_add_pcie_port() and qcom_add_pcie_port().
> 
> I can create a patch for histb driver, but will leave qcom one to
> Stanimir to decide.

Thanks, will see what can be done.

regards,
Stan