linux-kernel - Re: [PATCH] leds: lm3601x: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 May 2018 06:34:43 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Julia Lawall <julia.lawall@...6.fr>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <jacek.anaszewski@...il.com>, <pavel@....cz>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-leds@...r.kernel.org>, <kbuild-all@...org>
Subject: Re: [PATCH] leds: lm3601x: fix semicolon.cocci warnings

All

On 05/09/2018 03:26 AM, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@...el.com>
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver")
> CC: Dan Murphy <dmurphy@...com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> ---
> 
> url:
> https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> for-next
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
> 
> I also received the following comment, but no other details.  It would be
> good to check what is going on on the mentioned lines.
> 
>>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311
> 
>  leds-lm3601x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/leds/leds-lm3601x.c
> +++ b/drivers/leds/leds-lm3601x.c
> @@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led
> 
>  		ret = -EINVAL;
>  		goto out;
> -	};
> +	}
> 

I will fix this in v3 of the patch submission.

Dan

>  	if (led->strobe_timeout != current_timeout)
>  		ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG,
> 


-- 
------------------
Dan Murphy