linux-kernel - Re: [PATCH] staging: lustre: lnet: add static to libcfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 May 2018 10:43:23 +1000
From:   NeilBrown <neilb@...e.com>
To:     Justin Skists <justin.skists@...za.co.uk>,
        devel@...verdev.osuosl.org, lustre-devel@...ts.lustre.org,
        James Simmons <jsimmons@...radead.org>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Oleg Drokin <oleg.drokin@...el.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: lnet: add static to libcfs_dev declaration

On Thu, May 10 2018, Justin Skists wrote:

> Add a static prefix to the declaration for libcfs_dev. This would fix
> the following sparse warning:
>
> drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol
> 'libcfs_dev' was not declared. Should it be static?

Thanks - that was my fault. (b4ded66db93b)
Reviewed-by: NeilBrown <neilb@...e.com>

Thanks,
NeilBrown

>
> Signed-off-by: Justin Skists <justin.skists@...za.co.uk>
> ---
>  drivers/staging/lustre/lnet/libcfs/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs/module.c
> index ca942f474a55..e021e439f140 100644
> --- a/drivers/staging/lustre/lnet/libcfs/module.c
> +++ b/drivers/staging/lustre/lnet/libcfs/module.c
> @@ -314,7 +314,7 @@ static const struct file_operations libcfs_fops = {
>  	.unlocked_ioctl	= libcfs_psdev_ioctl,
>  };
>  
> -struct miscdevice libcfs_dev = {
> +static struct miscdevice libcfs_dev = {
>  	.minor = MISC_DYNAMIC_MINOR,
>  	.name = "lnet",
>  	.fops = &libcfs_fops,
> -- 
> 2.17.0

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)