linux-kernel - Re: [RFC PATCH v3 0/5] usb: typec: Support for Alternate Modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 May 2018 13:56:31 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jun Li <jun.li@....com>,
        Mats Karrman <mats.dev.list@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v3 0/5] usb: typec: Support for Alternate Modes

On Sat, May 12, 2018 at 02:42:47PM -0700, Guenter Roeck wrote:
> On 05/11/2018 06:18 AM, Heikki Krogerus wrote:
> > Hi,
> > 
> > This is the third version of my proposal for more complete alternate
> > mode support. In this version I'm including a proposal for the mux
> > handling. Basically, I'm proposing that every supported alternate will
> > have its own mux handle. That should allow us to support multiple
> > alternate modes at the same time. There is also a small change to how
> > I handled enter/exit mode commands. Now the alternate mode drivers
> > will need to check if Enter Mode command ACK/NAK. The ->enter callback
> > is not called in those cases separately. The typec_altmode_enter/exit
> > functions are used only when the command is initiated. Other than
> > that, only minor tuning.
> > 
> 
> I like the both the idea and the approach.

Thanks! :-)

> I browsed through the code, but I don't see anything obviously wrong
> with it. Too bad I wont have the time for an actual alternate mode
> implementation. Are you working on one, by any chance ? I would like
> to see this move forward, and an actual implementation would help
> to get there.

Yes, an alt mode implementation is definitely needed. I am working on
something, but I don't think I'm able to share anything before next
week unfortunately.


Thanks Guenter,

-- 
heikki