linux-kernel - Re: [PATCH v9 1/2] arch/*: Add CONFIG_ARCH_HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 May 2018 15:14:14 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "jcmvbkbc@...il.com" <jcmvbkbc@...il.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "deller@....de" <deller@....de>,
        "heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>,
        "hch@....de" <hch@....de>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "jejb@...isc-linux.org" <jejb@...isc-linux.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "chris@...kel.net" <chris@...kel.net>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "arnd@...db.de" <arnd@...db.de>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "schwidefsky@...ibm.com" <schwidefsky@...ibm.com>,
        "paulus@...ba.org" <paulus@...ba.org>
Subject: Re: [PATCH v9 1/2] arch/*: Add CONFIG_ARCH_HAVE_CMPXCHG64

On Tue, 2018-05-15 at 12:54 +1000, Michael Ellerman wrote:
> Bart Van Assche <bart.vanassche@....com> writes:
> > 
> > +    -----------------------
> > +    |         arch |status|
> > +    -----------------------
> > +    |       alpha: |  ok  |
> > +    |         arc: | TODO |
> > +    |         arm: |!thumb|
> > +    |       arm64: |  ok  |
> > +    |         c6x: | TODO |
> > +    |       h8300: | TODO |
> > +    |     hexagon: | TODO |
> > +    |        ia64: |  ok  |
> > +    |        m68k: |  ok  |
> > +    |  microblaze: | TODO |
> > +    |        mips: |64-bit|
> > +    |       nios2: | TODO |
> > +    |    openrisc: | TODO |
> > +    |      parisc: |  ok  |
> > +    |     powerpc: |64-bit|
> 
> I think that is correct for powerpc, we don't have a 32-bit
> implementation and there's no fallback it seems.
> 
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -150,6 +150,7 @@ config PPC
> >  	select ARCH_HAS_UBSAN_SANITIZE_ALL
> >  	select ARCH_HAS_ZONE_DEVICE		if PPC_BOOK3S_64
> >  	select ARCH_HAVE_NMI_SAFE_CMPXCHG
> > +	select ARCH_HAVE_CMPXCHG64
> 
> So shouldn't this should be:
> 
> +	select ARCH_HAVE_CMPXCHG64		if PPC64
> 
> And it should be sorted alphabetically, ie. above the previous NMI entry.

Hello Michael,

Thanks, I will make these changes.

Bart.