linux-kernel - [PATCH] intel_th: pti: Convert to use sysfs_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 May 2018 17:15:16 +0800
From:   Yisheng Xie <xieyisheng1@...wei.com>
To:     <alexander.shishkin@...ux.intel.com>
CC:     <heikki.krogerus@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
        "Yisheng Xie" <xieyisheng1@...wei.com>
Subject: [PATCH] intel_th: pti: Convert to use sysfs_match_string() helper

The helper returns index of the matching string in an array,
use it to simpler the code.

Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
---
 drivers/hwtracing/intel_th/pti.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/hwtracing/intel_th/pti.c b/drivers/hwtracing/intel_th/pti.c
index 5669433..75cb368 100644
--- a/drivers/hwtracing/intel_th/pti.c
+++ b/drivers/hwtracing/intel_th/pti.c
@@ -272,15 +272,12 @@ static ssize_t lpp_dest_store(struct device *dev, struct device_attribute *attr,
 			      const char *buf, size_t size)
 {
 	struct pti_device *pti = dev_get_drvdata(dev);
-	ssize_t ret = -EINVAL;
-	int i;
+	ssize_t ret;
 
-	for (i = 0; i < ARRAY_SIZE(lpp_dest_str); i++)
-		if (sysfs_streq(buf, lpp_dest_str[i]))
-			break;
+	ret = sysfs_match_string(lpp_dest_str, buf);
 
-	if (i < ARRAY_SIZE(lpp_dest_str) && pti->lpp_dest_mask & BIT(i)) {
-		pti->lpp_dest = i;
+	if (ret >= 0 && pti->lpp_dest_mask & BIT(ret)) {
+		pti->lpp_dest = ret;
 		ret = size;
 	}
 
-- 
1.7.12.4