linux-kernel - [PATCH] ASoC: codecs: fix pcm1789.c build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 May 2018 21:42:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     moderated for non-subscribers <alsa-devel@...a-project.org>
Cc:     Mylène Josserand <mylene.josserand@...tlin.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kbuild test robot <lkp@...el.com>
Subject: [PATCH] ASoC: codecs: fix pcm1789.c build errors

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors in pcm1789.c.
The source file needs to #include <linux/gpio/consumer.h> since it
uses interfaces and macros that are provided by it.
However, it does not need to #include <linux/gpio.h>, so drop it.

Fixes these build errors:

../sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init':
../sound/soc/codecs/pcm1789.c:247:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
  pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
../sound/soc/codecs/pcm1789.c:247:57: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function)
  pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
../sound/soc/codecs/pcm1789.c:251:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
  gpiod_set_value_cansleep(pcm1789->reset, 0);

Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789")
Reported-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Mylène Josserand <mylene.josserand@...tlin.com>
Cc: Liam Girdwood <lgirdwood@...il.com>
Cc: Mark Brown <broonie@...nel.org>
Cc: alsa-devel@...a-project.org
---
 sound/soc/codecs/pcm1789.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

BTW, MODULE_AUTHOR() still uses @free-electrons.com.

--- lnx-417-rc4.orig/sound/soc/codecs/pcm1789.c
+++ lnx-417-rc4/sound/soc/codecs/pcm1789.c
@@ -3,7 +3,7 @@
 // Copyright (C) 2018 Bootlin
 // Mylène Josserand <mylene.josserand@...tlin.com>
 
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/workqueue.h>