linux-kernel - Re: [PATCH v10 25/27] ARM: davinci: add device tree support to timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 May 2018 10:09:34 -0500
From:   David Lechner <david@...hnology.com>
To:     Sekhar Nori <nsekhar@...com>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kevin Hilman <khilman@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Adam Ford <aford173@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 25/27] ARM: davinci: add device tree support to timer

On 05/17/2018 09:35 AM, Sekhar Nori wrote:
> Hi David,
> 
> On Wednesday 09 May 2018 10:56 PM, David Lechner wrote:
>> This adds device tree support to the davinci timer so that when clocks
>> are moved to device tree, the timer will still work.
>>
>> Signed-off-by: David Lechner <david@...hnology.com>
>> ---
> 
>> +static int __init of_davinci_timer_init(struct device_node *np)
>> +{
>> +	struct clk *clk;
>> +
>> +	clk = of_clk_get(np, 0);
>> +	if (IS_ERR(clk)) {
>> +		struct of_phandle_args clkspec;
>> +
>> +		/*
>> +		 * Fall back to using ref_clk if the actual clock is not
>> +		 * available. There will be problems later if the real clock
>> +		 * source is disabled.
>> +		 */
>> +
>> +		pr_warn("%s: falling back to ref_clk\n", __func__);
>> +
>> +		clkspec.np = of_find_node_by_name(NULL, "ref_clk");
>> +		if (IS_ERR(clkspec.np)) {
>> +			pr_err("%s: No clock available for timer!\n", __func__);
>> +			return PTR_ERR(clkspec.np);
>> +		}
>> +		clk = of_clk_get_from_provider(&clkspec);
>> +		of_node_put(clkspec.np);
>> +	}
> 
> Do we need this error path now?
> 
> Thanks,
> Sekhar
> 

No, not really.