linux-kernel - Re: [tip:x86/cleanups] x86: Remove pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 May 2018 21:14:53 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Joe Perches <joe@...ches.com>
cc:     Borislav Petkov <bp@...en8.de>, mingo@...nel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/cleanups] x86: Remove pr_fmt duplicate logging
 prefixes

On Thu, 17 May 2018, Joe Perches wrote:
> On Thu, 2018-05-17 at 20:27 +0200, Borislav Petkov wrote:
> > On Sun, May 13, 2018 at 12:27:45PM -0700, tip-bot for Joe Perches wrote:
> > > Commit-ID:  1de392f5d5e803663abbd8ed084233f154152bcd
> > > Gitweb:     https://git.kernel.org/tip/1de392f5d5e803663abbd8ed084233f154152bcd
> > > Author:     Joe Perches <joe@...ches.com>
> > > AuthorDate: Thu, 10 May 2018 08:45:30 -0700
> > > Committer:  Thomas Gleixner <tglx@...utronix.de>
> > > CommitDate: Sun, 13 May 2018 21:25:18 +0200
> > > 
> > > x86: Remove pr_fmt duplicate logging prefixes
> > > 
> > > Converting pr_fmt from a default simple #define to use KBUILD_MODNAME
> > > added some duplicate prefixes.
> > > 
> > > Remove the duplicate prefixes.
> []
> > Maybe I'm missing something but this dropped the prefixes now
> > completely:
> > 
> > -e820: BIOS-provided physical RAM map:
> > +BIOS-provided physical RAM map:
> > 
> > -e820: last_pfn = 0x43f000 max_arch_pfn = 0x400000000
> > +last_pfn = 0x43f000 max_arch_pfn = 0x400000000
> > 
> > -e820: last_pfn = 0x9d000 max_arch_pfn = 0x400000000
> > +last_pfn = 0x9d000 max_arch_pfn = 0x400000000
> > 
> > ...
> > 
> > I don't think that was the intention.
> 
> Hi Borislav
> 
> It wasn't and isn't the intention.
> 
> This is a patch _series_, and all of the patches
> from 4-18 depend on patch 3 which converts the
> generic define in include/linux/printk.h
> 
> from
> 	#define pr_fmt(fmt) fmt
> to
> 	#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> Perhaps a better option, which could be done in
> a v2 of the series, is to add a temporary
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> to each file modified in patches 4-18 and then
> allow the follow-on script described in the 0/18
> cover letter to remove those #defines

Yes, I think thats the right thing todo.

Thanks,

	tglx