linux-kernel - RE: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 May 2018 19:33:44 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Roman Kagan <rkagan@...tuozzo.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        Mohammed Gamal <mmorsy@...hat.com>,
        Cathy Avery <cavery@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
 definitions to common header



> -----Original Message-----
> From: Vitaly Kuznetsov <vkuznets@...hat.com>
> Sent: Thursday, May 17, 2018 12:06 AM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: kvm@...r.kernel.org; x86@...nel.org; Paolo Bonzini
> <pbonzini@...hat.com>; Radim Krčmář <rkrcmar@...hat.com>; Roman
> Kagan <rkagan@...tuozzo.com>; Haiyang Zhang <haiyangz@...rosoft.com>;
> Stephen Hemminger <sthemmin@...rosoft.com>; Michael Kelley (EOSG)
> <Michael.H.Kelley@...rosoft.com>; Mohammed Gamal
> <mmorsy@...hat.com>; Cathy Avery <cavery@...hat.com>; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
> definitions to common header
> 
> KY Srinivasan <kys@...rosoft.com> writes:
> 
> >> -----Original Message-----
> >> From: Vitaly Kuznetsov <vkuznets@...hat.com>
> >> Sent: Wednesday, May 16, 2018 8:21 AM
> >> To: kvm@...r.kernel.org
> >> Cc: x86@...nel.org; Paolo Bonzini <pbonzini@...hat.com>; Radim
> Krčmář
> >> <rkrcmar@...hat.com>; Roman Kagan <rkagan@...tuozzo.com>; KY
> >> Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> >> <haiyangz@...rosoft.com>; Stephen Hemminger
> >> <sthemmin@...rosoft.com>; Michael Kelley (EOSG)
> >> <Michael.H.Kelley@...rosoft.com>; Mohammed Gamal
> >> <mmorsy@...hat.com>; Cathy Avery <cavery@...hat.com>; linux-
> >> kernel@...r.kernel.org
> >> Subject: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
> >> definitions to common header
> >>
> >> Hyper-V TLB flush hypercalls definitions will be required for KVM so move
> >> them hyperv-tlfs.h. Structures also need to be renamed as '_pcpu' suffix
> is
> >> irrelevant for a general-purpose definition.
> >>
> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> >> ---
> >>  arch/x86/hyperv/mmu.c              | 40 ++++++++++----------------------------
> >>  arch/x86/include/asm/hyperv-tlfs.h | 20 +++++++++++++++++++
> >>  2 files changed, 30 insertions(+), 30 deletions(-)
> >
> > Vitaly,
> >
> > We should  coordinate on this; I have patches in flight that conflict with
> > the changes here.
> 
> I see you also fixed 'HV_GENERIC_SET_SPARCE_4K' typo. I don't think it's
> a big deal as we fix it in the same way :-)
> 
> I see you also altered hv_flush_pcpu_ex definition but kept it in mmu.c:
> I think my patches should be applied on top of yours, I only need to
> move it to hyperv-tlfs.h header and get rid of _pcpu suffix.
> 
> I hope Thomas will merge your patches very soon. In case Paolo/Radim
> decide that my series is ready too we'll ask their guidance on how to
> resolve the conflict (topic branch?). It should be relatively easy.

I agree; waiting for Thomas to merge.

K. Y
> 
> Thanks,
> 
> --
>   Vitaly