linux-kernel - Re: [PATCH] tty: add missing const to termios hw-change helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 May 2018 10:14:11 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Johan Hovold <johan@...nel.org>, Jiri Slaby <jslaby@...e.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] tty: add missing const to termios hw-change helper

On Mon, May 21, 2018 at 06:41:30PM +0200, Greg Kroah-Hartman wrote:
> On Mon, May 21, 2018 at 01:08:44PM +0200, Johan Hovold wrote:
> > Add missing const qualifiers to the termios hw-change helper parameters,
> > which is used by few USB serial drivers. This specifically allows the
> > pl2303 driver to use const arguments in one of its helper as well.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Jiri Slaby <jslaby@...e.com>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> > 
> > Greg, are you fine with me taking this one through my tree, or do prefer
> > I split out the pl2303 bits?
> > 
> > Note that this helper is only used by a few USB serial drivers and that
> > the pl2303 bits depend on a new patch targeted for -next.
> 
> Your tree is fine:
> 
> 	Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

I made this patch a prerequisite of the pl2303 change so that I could
use const there from the start instead (i.e. I dropped the pl2303 chunk
from this one).

Now applied.

Thanks,
Johan