linux-kernel - Re: [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 14:26:41 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     dmeyer@...aio.com, kurt.schwemmer@...rosemi.com,
        linux-pci@...r.kernel.org, linux-ntb@...glegroups.com
Cc:     bhelgaas@...gle.com, jdmason@...zu.us, dave.jiang@...el.com,
        allenbh@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI
 Header



On 23/05/18 02:18 PM, dmeyer@...aio.com wrote:
> +#define PCI_DEVICE_ID_MICROSEMI_PFX24XG3	0x8531

I think Bjorn asked not to add the device IDs to the pci_ids.h and to
just use the raw IDs in quirks.h. switchtec.c already uses the raw values.

Besides that, it looks good to me.

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>