linux-kernel - Re: [RESEND PATCH] PCI: qcom: add runtime pm support to pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 16:16:04 +0530
From:   Vinod <vkoul@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stanimir Varbanov <svarbanov@...sol.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] PCI: qcom: add runtime pm support to pcie_port

On 23-05-18, 11:10, Srinivas Kandagatla wrote:
> 
> 
> On 23/05/18 07:15, Vinod wrote:
> > On 18-05-18, 00:07, Bjorn Andersson wrote:
> > 
> > > diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> > > index 5897af7d3355..3f35098b71b1 100644
> > > --- a/drivers/pci/dwc/pcie-qcom.c
> > > +++ b/drivers/pci/dwc/pcie-qcom.c
> > > @@ -1088,6 +1088,8 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
> > >   	struct qcom_pcie *pcie = to_qcom_pcie(pci);
> > >   	int ret;
> > > +	pm_runtime_get_sync(pci->dev);
> > > +
> > >   	qcom_ep_reset_assert(pcie);
> > >   	ret = pcie->ops->init(pcie);
> > > @@ -1124,6 +1126,7 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
> > >   	phy_power_off(pcie->phy);
> > >   err_deinit:
> > >   	pcie->ops->deinit(pcie);
> > > +	pm_runtime_put_sync(pci->dev);
> > 
> > Wondering if there is a reason for sync put here?
> pm_runtime_get_sync() call paired with a pm_runtime_put() call will be
> appropriate here I guess as per
> https://www.kernel.org/doc/Documentation/power/runtime_pm.txt

Yeah for the get call sync() is mostly appropriate as you would want hardware to
be up after this. For put most of cases people don't need it to be bought down
synchronously unless you have something specific required which was my question
here. Looks like that is not the case :)

> I will respin this patch.

Sure..

-- 
~Vinod