lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 May 2018 18:20:41 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: netdev@...r.kernel.org, arunp@...adcom.com, "David S. Miller" <davem@...emloft.net>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Jon Mason <jonmason@...adcom.com>, "maintainer:BROADCOM IPROC ARM ARCHITECTURE" <bcm-kernel-feedback-list@...adcom.com>, "moderated list:BROADCOM IPROC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp() Hi Andrew, On 05/22/2018 05:15 PM, Andrew Lunn wrote: > On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: >> On newer PHYs, we need to select the expansion register to write with >> setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior >> to being migrated to generic code under bcm-phy-lib.c which >> unfortunately used the older implementation from the BCM54xx days. > > Hi Florian > > Does selecting the expansion register affect access to the standard > registers? Does this need locking like the Marvell PHY has when > changing pages? We should probably convert this to the page accessors since the expansion, misc and other shadow 0x1c accesses are all indirection layers to poke into a different address space of the PHY. That would be a separate fix though for a number of reasons. -- Florian
Powered by blists - more mailing lists