linux-kernel - Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 13:48:23 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        linux-mtd@...ts.infradead.org,
        Atsushi Nemoto <anemo@....ocn.ne.jp>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of
 OFFSET_CONTINUOUS

On Tue, 22 May 2018 17:07:53 +0200
Geert Uytterhoeven <geert+renesas@...der.be> wrote:

> The comment about offset zero was not updated when changing behavior:
>   - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
>   - Zero really means offset zero.
> 
> Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Applied.

Thanks,

Boris

> ---
>  drivers/mtd/cmdlinepart.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
> index fbd5affc0acfe3fe..3ea44cff9b759e3c 100644
> --- a/drivers/mtd/cmdlinepart.c
> +++ b/drivers/mtd/cmdlinepart.c
> @@ -190,7 +190,10 @@ static struct mtd_partition * newpart(char *s,
>  		extra_mem = (unsigned char *)(parts + *num_parts);
>  	}
>  
> -	/* enter this partition (offset will be calculated later if it is zero at this point) */
> +	/*
> +	 * enter this partition (offset will be calculated later if it is
> +	 * OFFSET_CONTINUOUS at this point)
> +	 */
>  	parts[this_part].size = size;
>  	parts[this_part].offset = offset;
>  	parts[this_part].mask_flags = mask_flags;