linux-kernel - Re: [PATCH v1] MIPS: PCI: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 08:48:47 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     James Hogan <jhogan@...nel.org>
Cc:     linux-pci@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] MIPS: PCI: Use dev_printk() when possible

On Wed, May 23, 2018 at 09:14:48AM +0100, James Hogan wrote:
> On Tue, May 22, 2018 at 08:11:42AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > Use the pci_info() and pci_err() wrappers for dev_printk() when possible.
> > 
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > ---
> >  arch/mips/pci/pci-legacy.c |    7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/mips/pci/pci-legacy.c b/arch/mips/pci/pci-legacy.c
> > index 0c65c38e05d6..73643e80f02d 100644
> > --- a/arch/mips/pci/pci-legacy.c
> > +++ b/arch/mips/pci/pci-legacy.c
> > @@ -263,9 +263,7 @@ static int pcibios_enable_resources(struct pci_dev *dev, int mask)
> >  				(!(r->flags & IORESOURCE_ROM_ENABLE)))
> >  			continue;
> >  		if (!r->start && r->end) {
> > -			printk(KERN_ERR "PCI: Device %s not available "
> > -			       "because of resource collisions\n",
> > -			       pci_name(dev));
> > +			pci_err(dev, "can't enable device: resource collisions\n");
> 
> The pedantic side of me wants to point out that you could wrap that line
> after the comma to keep it within 80 columns.

Done, thanks!

> Either way though:
> Acked-by: James Hogan <jhogan@...nel.org>
> 
> Cheers
> James