linux-kernel - Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 16:58:11 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Guenter Roeck <groeck@...gle.com>
Cc:     Takashi Iwai <tiwai@...e.de>, Liam Girdwood <lgirdwood@...il.com>,
        alsa-devel@...a-project.org, Guenter Roeck <groeck@...omium.org>,
        "Patel, Chintan M" <chintan.m.patel@...el.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility
 with v4 topology files

On Wed, May 23, 2018 at 08:54:18AM -0700, Guenter Roeck wrote:
> On Wed, May 23, 2018 at 6:56 AM Mark Brown <broonie@...nel.org> wrote:
> > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote:

> > > And I'm wondering whether we should move these definitions to uapi
> > > headers.

> > Yes, we should.

> Are you sure ? They used to be in
>  sound/soc/intel/skylake/skl-tplg-interface.h.
> I took my clue from sound/soc/soc-topology.c, where the v4 structures are
> also
> declared locally and not in the uapi files.

I'm saying we should move them there.  They're clearly part of the
userspace ABI and therefore belong in uapi, it was a mistake to let them
be elsewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)