linux-kernel - [PATCH] afs/server: Remove leftover variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 11:38:01 +0200
From:   Anna-Maria Gleixner <anna-maria@...utronix.de>
To:     linux-afs@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, dhowells@...hat.com,
        Anna-Maria Gleixner <anna-maria@...utronix.de>
Subject: [PATCH] afs/server: Remove leftover variable

Variable ret is set two times in afs_install_server() but never
dereferenced. It is a leftover of a rework of afs_install_server() by
commit d2ddc776a458 ("afs: Overhaul volume and server record caching and
fileserver rotation").

Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
---
 fs/afs/server.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/afs/server.c b/fs/afs/server.c
index 3af4625e2f8c..b69a70362bd5 100644
--- a/fs/afs/server.c
+++ b/fs/afs/server.c
@@ -153,7 +153,7 @@ static struct afs_server *afs_install_server(struct afs_net *net,
 	const struct afs_addr_list *alist;
 	struct afs_server *server;
 	struct rb_node **pp, *p;
-	int ret = -EEXIST, diff;
+	int diff;
 
 	_enter("%p", candidate);
 
@@ -198,7 +198,6 @@ static struct afs_server *afs_install_server(struct afs_net *net,
 		hlist_add_head_rcu(&server->addr6_link, &net->fs_addresses6);
 
 	write_sequnlock(&net->fs_addr_lock);
-	ret = 0;
 
 exists:
 	afs_get_server(server);
-- 
2.15.1