linux-kernel - [PATCH] udmabuf: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 16:29:50 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Gerd Hoffmann <kraxel@...hat.com>
cc:     kbuild-all@...org, linux-media@...r.kernel.org,
        Sumit Semwal <sumit.semwal@...aro.org>,
        dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] udmabuf: fix odd_ptr_err.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>

drivers/dma-buf/udmabuf.c:167:6-12: inconsistent IS_ERR and PTR_ERR on line 168.

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: cc2d0e91bc15 ("udmabuf: driver update")
Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: linux-kernel@...r.kernel.org
---

tree:   git://git.kraxel.org/linux udmabuf
head:   cc2d0e91bc15849baff695d175bfb8fba35f1465
commit: cc2d0e91bc15849baff695d175bfb8fba35f1465 [6/6] udmabuf: driver
update

 udmabuf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -165,7 +165,7 @@ static long udmabuf_ioctl_create(struct
 		page = shmem_read_mapping_page(
 			file_inode(ubuf->filp)->i_mapping, pgoff + pgidx);
 		if (IS_ERR(page)) {
-			ret = PTR_ERR(buf);
+			ret = PTR_ERR(page);
 			goto err_put_pages;
 		}
 		ubuf->pages[pgidx] = page;