linux-kernel - Re: [PATCH] drm: check_pixel_format() should return true if no modifiers are passed for a supported pixel format

Open Source and information security mailing list archives

Date:   Fri, 25 May 2018 18:54:56 +0300
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     Ayan Kumar Halder <ayan.halder@....com>
Cc:     liviu.dudau@....com, brian.starkey@....com,
        alexandru-cosmin.gheorghe@....com, gustavo@...ovan.org,
        maarten.lankhorst@...ux.intel.com, seanpaul@...omium.org,
        airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, nd@....com
Subject: Re: [PATCH] drm: check_pixel_format() should return true if no
 modifiers are passed for a supported pixel format

On Fri, May 25, 2018 at 04:35:41PM +0100, Ayan Kumar Halder wrote:
> If a plane supports a pixel format and the framebuffer does not pass any
> modifiers, then drm_plane_check_pixel_format() should always return true
> for the given format regardless of whether the plane supports any
> modifiers or not.

If your plane supports DRM_FORMAT_MOD_LINEAR then you should add that
to the plane's modifier list.

> 
> Signed-off-by: Ayan Kumar Halder <ayan.halder@....com>
> ---
>  drivers/gpu/drm/drm_plane.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 6d2a6e4..873c084 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -564,6 +564,9 @@ int drm_plane_check_pixel_format(struct drm_plane *plane,
>  	if (!plane->modifier_count)
>  		return 0;
>  
> +	if (modifier == DRM_FORMAT_MOD_NONE)
> +		return 0;
> +
>  	for (i = 0; i < plane->modifier_count; i++) {
>  		if (modifier == plane->modifiers[i])
>  			break;
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives