linux-kernel - [PATCH] memory: tegra: include linux/spinlock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 23:11:39 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] memory: tegra: include linux/spinlock.h

The newly added code in this file causes a build error unless
we include linux/spinlock.h, at least in some configurations:

In file included from drivers/memory/tegra/mc.h:15,
                 from drivers/memory/tegra/tegra20.c:11:
include/soc/tegra/mc.h:159:2: error: unknown type name 'spinlock_t'
  spinlock_t lock;
  ^~~~~~~~~~
drivers/memory/tegra/tegra20.c: In function 'terga20_mc_hotreset_assert':
drivers/memory/tegra/tegra20.c:207:2: error: implicit declaration of function 'spin_lock_irqsave'; did you mean 'arch_local_irq_save'? [-Werror=implicit-function-declaration]
  spin_lock_irqsave(&mc->lock, flags);
  ^~~~~~~~~~~~~~~~~

Fixes: cb557757e1aa ("memory: tegra: Add Tegra20 memory controller hot resets")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/memory/tegra/tegra20.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/memory/tegra/tegra20.c b/drivers/memory/tegra/tegra20.c
index 7119e532471c..8853e21b773f 100644
--- a/drivers/memory/tegra/tegra20.c
+++ b/drivers/memory/tegra/tegra20.c
@@ -6,6 +6,7 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/spinlock.h>
 #include <dt-bindings/memory/tegra20-mc.h>
 
 #include "mc.h"
-- 
2.9.0