linux-kernel - Re: [PATCH] i2c: i801: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 23:57:43 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i801: mark PM functions as __maybe_unused

On Fri, May 25, 2018 at 11:09:46PM +0200, Arnd Bergmann wrote:
> Changing from UNIVERSAL_DEV_PM_OPS to SIMPLE_DEV_PM_OPS caused a harmless
> warning in configurations without CONFIG_PM_SLEEP:
> 
> drivers/i2c/busses/i2c-i801.c:1723:12: error: 'i801_resume' defined but not used [-Werror=unused-function]
>  static int i801_resume(struct device *dev)
>             ^~~~~~~~~~~
> drivers/i2c/busses/i2c-i801.c:1714:12: error: 'i801_suspend' defined but not used [-Werror=unused-function]
>  static int i801_suspend(struct device *dev)
> 
> This removes the incorrect #ifdef and instead marks both functions as
> __maybe_unused, which is a more robust way to express the same thing.
> 
> Fixes: a9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Should be fixed in my for-next branch:

https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/drivers/i2c/busses/i2c-i801.c?h=i2c/for-next&id=4b2f9bd5e39fb47011074c9a26b64b616acc18f0


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)