linux-kernel - RE: [PATCH, net-next] net/mlx5e: fix TLS dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 May 2018 14:17:02 +0000
From:   Boris Pismenny <borisp@...lanox.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "arnd@...db.de" <arnd@...db.de>,
        "leon@...nel.org" <leon@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Feras Daoud <ferasda@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH, net-next] net/mlx5e: fix TLS dependency

Acked-by: Boris Pismenny <borisp@...lanox.com>

Thank you.

> -----Original Message-----
> From: Saeed Mahameed
> Sent: Saturday, May 26, 2018 2:19 AM
> To: davem@...emloft.net; arnd@...db.de; leon@...nel.org
> Cc: linux-kernel@...r.kernel.org; linux-rdma@...r.kernel.org; Boris
> Pismenny <borisp@...lanox.com>; Or Gerlitz <ogerlitz@...lanox.com>;
> Feras Daoud <ferasda@...lanox.com>; Ilan Tayari <ilant@...lanox.com>;
> netdev@...r.kernel.org; Ilya Lesokhin <ilyal@...lanox.com>
> Subject: Re: [PATCH, net-next] net/mlx5e: fix TLS dependency
> 
> On Fri, 2018-05-25 at 23:36 +0200, Arnd Bergmann wrote:
> > With CONFIG_TLS=m and MLX5_CORE_EN=y, we get a link failure:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In
> > function `mlx5e_tls_handle_ooo':
> > tls_rxtx.c:(.text+0x24c): undefined reference to `tls_get_record'
> > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In
> > function `mlx5e_tls_handle_tx_skb':
> > tls_rxtx.c:(.text+0x9a8): undefined reference to
> > `tls_device_sk_destruct'
> >
> > This narrows down the dependency to only allow the configurations that
> > will actually work. The existing dependency on TLS_DEVICE is not
> > sufficient here since MLX5_EN_TLS is a 'bool' symbol.
> >
> > Fixes: c83294b9efa5 ("net/mlx5e: TLS, Add Innova TLS TX support")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> 
> LGTM
> 
> Acked-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> Thank you Arnd!
> 
> 
> >  drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > index ee6684779d11..2545296a0c08 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > @@ -91,6 +91,7 @@ config MLX5_EN_TLS
> >  	bool "TLS cryptography-offload accelaration"
> >  	depends on MLX5_CORE_EN
> >  	depends on TLS_DEVICE
> > +	depends on TLS=y || MLX5_CORE=m
> >  	depends on MLX5_ACCEL
> >  	default n
> >  	---help---