lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 May 2018 11:46:41 +1000 From: "Tobin C. Harding" <me@...in.cc> To: Andrew Morton <akpm@...ux-foundation.org> Cc: "Tobin C. Harding" <me@...in.cc>, Linus Torvalds <torvalds@...ux-foundation.org>, Randy Dunlap <rdunlap@...radead.org>, Steven Rostedt <rostedt@...dmis.org>, Kees Cook <keescook@...omium.org>, Anna-Maria Gleixner <anna-maria@...utronix.de>, "Theodore Ts'o" <tytso@....edu>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org Subject: [PATCH v6 3/4] vsprintf: Use hw RNG for ptr_key Currently we must wait for enough entropy to become available before hashed pointers can be printed. We can remove this wait by using the hw RNG if available. Use hw RNG to get keying material. Cc: Steven Rostedt (VMware) <rostedt@...dmis.org> Suggested-by: Kees Cook <keescook@...omium.org> Signed-off-by: Tobin C. Harding <me@...in.cc> --- lib/vsprintf.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 23920c5ff728..1545a8aa26a9 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1693,8 +1693,16 @@ static struct random_ready_callback random_ready = { static int __init initialize_ptr_random(void) { - int ret = add_random_ready_callback(&random_ready); + int key_size = sizeof(ptr_key); + int ret; + + /* Use hw RNG if available */ + if (get_random_bytes_arch(&ptr_key, key_size) == key_size) { + static_branch_disable(¬_filled_random_ptr_key); + return 0; + } + ret = add_random_ready_callback(&random_ready); if (!ret) { return 0; } else if (ret == -EALREADY) { -- 2.7.4
Powered by blists - more mailing lists