linux-kernel - [PATCH] platform: chrome: Add input dependency for tablet switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 May 2018 17:58:46 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Benson Leung <bleung@...omium.org>, Olof Johansson <olof@...om.net>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Gwendal Grignou <gwendal@...omium.org>,
        Thierry Escande <thierry.escande@...labora.com>,
        Lee Jones <lee.jones@...aro.org>,
        Shawn Nematbakhsh <shawnn@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] platform: chrome: Add input dependency for tablet switch driver

Without CONFIG_INPUT, or with a modular input layer and built-in
tablet driver, we get a link error:

ERROR: "input_event" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
ERROR: "input_register_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
ERROR: "input_set_capability" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
ERROR: "devm_input_allocate_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!

This adds the corresponding Kconfig dependency

Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/platform/chrome/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index 57aabe6e94a3..cb0df9eb3e0f 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -41,6 +41,7 @@ config CHROMEOS_PSTORE
 config CHROMEOS_TBMC
 	tristate "ChromeOS Tablet Switch Controller"
 	depends on ACPI
+	depends on INPUT
 	help
 	  This option adds a driver for the tablet switch on
 	  select Chrome OS systems.
-- 
2.9.0