linux-kernel - Re: [PATCH v4] usbip: dynamically allocate idev by nports found in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 May 2018 15:28:55 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>,
        linux-usb@...r.kernel.org
Cc:     valentina.manea.m@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v4] usbip: dynamically allocate idev by nports found in
 sysfs

On 05/25/2018 08:23 AM, Michael Grzeschik wrote:
> As the amount of available ports varies by the kernels build
> configuration. To remove the limitation of the fixed 128 ports
> we allocate the amount of idevs by using the number we get
> from the kernel.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
> ---
> v1 -> v2: - reworked memory allocation into one calloc call
>           - added error path on allocation failure
> v2 -> v3: - moved check for available nports to beginning of function
> v3 -> v4: - changed get_nports to get hc_device via parameter
>           - moved calloc after valid get_nports call
> 

Thanks. Looks good to me. It works now and doesn't segfault :)

Acked-by: Shuah Khan (Samsung OSG) <shuah@...nel.org>

thanks,
-- Shuah