linux-kernel - Re: [PATCH] phy: tegra: select USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 May 2018 01:12:52 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Arnd Bergmann <arnd@...db.de>, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Thierry Reding <treding@...dia.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: tegra: select USB_COMMON

On 31.05.2018 00:33, Arnd Bergmann wrote:
> A built-in PHY driver cannot link against modular USB core code:
> 
> drivers/usb/phy/phy-tegra-usb.o: In function `tegra_usb_phy_probe':
> phy-tegra-usb.c:(.text+0x6bc): undefined reference to `usb_get_dr_mode'
> 
> This uses a 'select' statement in Kconfig like we have for other such
> PHY drivers.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/usb/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index b9b0a44be679..d7312eed6088 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -162,6 +162,7 @@ config USB_MXS_PHY
>  config USB_TEGRA_PHY
>  	tristate "NVIDIA Tegra USB PHY Driver"
>  	depends on ARCH_TEGRA
> +	select USB_COMMON
>  	select USB_PHY
>  	select USB_ULPI
>  	help
> 

Thank you!

Reviewed-by: Dmitry Osipenko <digetx@...il.com>