linux-kernel - Re: [PATCH v4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 14:03:34 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Rohit Khatri <rohit.khatri@...onnectline.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4.17-rc7 1/1] lib/kobject_uevent : fix uevent
 environment variable update with kobject event

On Wed, May 30, 2018 at 11:36:26AM +0000, Rohit Khatri wrote:
> From: Rohit Khatri <rohit.khatri@...onnectline.com><mailto:rohit.khatri@...onnectline.com>
> Subject: [PATCH 4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event

What are these lines doing in the email body?

> Function kobject_uevent_env is unable to update uevent variables as sequence of code is overwriting user added environment variable(s).
> For example, if there is a variable named "KEY" in uevent environment with initial value of 0 and if update on any event using  kobject_uevent_env function, value of variable would be 0 only or whatever is initialized because after loading user called variable, function is again reloading same variables.

Please always wrap your changelog lines at the proper column, like your
editor asked you to when you wrote the patch.

> Signed-off-by: Rohit Khatri <rohit.khatri@...onnectline.com><mailto:rohit.khatri@...onnectline.com>
> Cc: stable@...r.kernel.org<mailto:stable@...r.kernel.org>

What is with the crazy mailto: stuff?

Please fix up and we can review the patch...

Also, does this "fix" a patch that is already in the tree?  If so,
please use the Fixes: tag to specify what commit it fixes.

thanks,

greg k-h