linux-kernel - Re: linux-next: build failure after merge of the device-mapper tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 22:35:40 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Alasdair G Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...hat.com>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: linux-next: build failure after merge of the device-mapper tree

On May 30, 2018, at 10:23 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> 
> Hi all,
> 
> After merging the device-mapper tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/md/dm-writecache.c: In function 'writecache_dtr':
> drivers/md/dm-writecache.c:1799:3: error: implicit declaration of function 'bioset_free'; did you mean 'bvec_free'? [-Werror=implicit-function-declaration]
>   bioset_free(wc->bio_set);
>   ^~~~~~~~~~~
>   bvec_free
> drivers/md/dm-writecache.c: In function 'writecache_ctr':
> drivers/md/dm-writecache.c:1929:17: error: implicit declaration of function 'bioset_create'; did you mean 'bioset_exit'? [-Werror=implicit-function-declaration]
>   wc->bio_set = bioset_create(BIO_POOL_SIZE,
>                 ^~~~~~~~~~~~~
>                 bioset_exit
> drivers/md/dm-writecache.c:1929:15: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>   wc->bio_set = bioset_create(BIO_POOL_SIZE,
>               ^
> 
> Caused by commit
> 
>  2105231db61b ("dm: add writecache target")
> 
> interacting with commit
> 
>  dad08527525f ("block: Drop bioset_create()")
> 
> from the block tree.
> 
> Can we please consider not immediately dropping APIs if at all
> possible. :-(

I’ll drop the last patch, we can do that at the end of the merge window instead.