linux-kernel - [PATCH] gpio: dwapb: fix a signedness bug handling IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 May 2018 09:24:24 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Hoan Tran <hotran@....com>,
        Phil Edworthy <phil.edworthy@...esas.com>
Cc:     Hoan Tran <hotran@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] gpio: dwapb: fix a signedness bug handling IRQs

Smatch flags a couple bugs here:

drivers/gpio/gpio-dwapb.c:447 dwapb_configure_irqs() warn: always true condition '(pp->irq[i] >= 0) => (0-u32max >= 0)'
drivers/gpio/gpio-dwapb.c:627 dwapb_gpio_get_pdata() warn: always true condition '(pp->irq[j] >= 0) => (0-u32max >= 0)'

The problem is that we're storing error codes in pp->irq[] so it needs
to be signed for the error handling to work correctly.

Fixes: da069d5d2b81 ("gpio: dwapb: Rework support for 1 interrupt per port A GPIO")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/include/linux/platform_data/gpio-dwapb.h b/include/linux/platform_data/gpio-dwapb.h
index 5a52d69c13f3..419cfacb4b42 100644
--- a/include/linux/platform_data/gpio-dwapb.h
+++ b/include/linux/platform_data/gpio-dwapb.h
@@ -19,7 +19,7 @@ struct dwapb_port_property {
 	unsigned int	idx;
 	unsigned int	ngpio;
 	unsigned int	gpio_base;
-	unsigned int	irq[32];
+	int		irq[32];
 	bool		has_irq;
 	bool		irq_shared;
 };