linux-kernel - Re: [PATCH] i2c: qup: fix building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 May 2018 23:23:07 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Abhishek Sahu <absahu@...eaurora.org>,
        Austin Christ <austinwc@...eaurora.org>,
        Sricharan R <sricharan@...eaurora.org>,
        Bhumika Goyal <bhumirks@...il.com>,
        Peter Rosin <peda@...ntia.se>, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: qup: fix building without CONFIG_ACPI

On Wed, May 30, 2018 at 11:31:49PM +0200, Arnd Bergmann wrote:
> The added Centriq support broke compilation with CONFIG_ACPI disabled:
> 
> drivers/i2c/busses/i2c-qup.c: In function 'qup_i2c_probe':
> drivers/i2c/busses/i2c-qup.c:1707:25: error: 'qup_i2c_acpi_match' undeclared (first use in this function); did you mean 'qup_i2c_recv_data'?
> 
> This fixes it by removing the extraneous #ifdef. All ACPI specific
> code will be dropped implicitly when that option is disabled, but
> the compiler first needs to see it.
> 
> Fixes: 902a91a02bdf ("i2c: qup: add probe path for Centriq ACPI devices")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)