linux-kernel - Re: [PATCH 3/8] media: uniphier: add submodules of HSC MPEG2-TS I/O driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Jun 2018 20:59:00 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
Cc:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        linux-media@...r.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/8] media: uniphier: add submodules of HSC MPEG2-TS I/O driver

2018-05-30 18:09 GMT+09:00 Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>:
> This patch adds submodules of HSC for UniPhier SoCs.
> These work as follows:
>   ucode: Load uCode and start subsystems
>   css  : Switch stream path
>   ts   : Receive MPEG2-TS clock and signal
>   dma  : Transfer MPEG2-TS data bytes to main memory
>
> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
> ---
>  drivers/media/platform/uniphier/Makefile    |   3 +
>  drivers/media/platform/uniphier/hsc-css.c   | 258 ++++++++++++
>  drivers/media/platform/uniphier/hsc-dma.c   | 302 ++++++++++++++
>  drivers/media/platform/uniphier/hsc-ts.c    |  99 +++++
>  drivers/media/platform/uniphier/hsc-ucode.c | 436 ++++++++++++++++++++
>  5 files changed, 1098 insertions(+)
>  create mode 100644 drivers/media/platform/uniphier/hsc-css.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
>  create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
>
> diff --git a/drivers/media/platform/uniphier/Makefile b/drivers/media/platform/uniphier/Makefile
> index f66554cd5c45..92536bc56b31 100644
> --- a/drivers/media/platform/uniphier/Makefile
> +++ b/drivers/media/platform/uniphier/Makefile
> @@ -1 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
> +uniphier-dvb-y += hsc-ucode.o hsc-css.o hsc-ts.o hsc-dma.o
> +
> +obj-$(CONFIG_DVB_UNIPHIER) += uniphier-dvb.o



If you claim this driver is tristate,
you need to do compile-test with =m.


I see the following warning for allmodconfig.


  CC [M]  drivers/media/platform/uniphier/hsc-ucode.o
  CC [M]  drivers/media/platform/uniphier/hsc-css.o
  CC [M]  drivers/media/platform/uniphier/hsc-ts.o
  CC [M]  drivers/media/platform/uniphier/hsc-dma.o
  LD [M]  drivers/media/platform/uniphier/uniphier-dvb.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/media/platform/uniphier/uniphier-dvb.o
see include/linux/module.h for more information










-- 
Best Regards
Masahiro Yamada