linux-kernel - Re: dm-crypt: fix warning in shutdown path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eeea0f12-45d4-d90c-e07e-3f02cdc9994f@kernel.dk>
Date:   Sat, 2 Jun 2018 14:10:23 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Mike Snitzer <snitzer@...hat.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Kent Overstreet <kent.overstreet@...il.com>, dm-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: dm-crypt: fix warning in shutdown path

On 6/2/18 2:07 PM, Mike Snitzer wrote:
> On Sat, Jun 02 2018 at  4:03pm -0400,
> Jens Axboe <axboe@...nel.dk> wrote:
> 
>> On 6/2/18 11:45 AM, Kent Overstreet wrote:
>>> The counter for the number of allocated pages includes pages in the
>>> mempool's reserve, so checking that the number of allocated pages is 0
>>> needs to happen after we exit the mempool.
>>
>> Looks good, but needs a fixes line. I'll add one.
> 
> Also needs the subject and header updated to reflect that it fixes the
> crash (Krzysztof please verify):
> 
> Reported-by: Krzysztof Kozlowski <krzk@...nel.org>
> Acked-by: Mike Snitzer <snitzer@...hat.com>

Indeed, I have added that. Thanks Mike.

-- 
Jens Axboe