linux-kernel - Re: [PATCH V1 3/3] scsi: ufs: Add sysfs support for ufs provision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jun 2018 10:42:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stanislav Nijnikov <Stanislav.Nijnikov@....com>
Cc:     Sayali Lokhande <sayalil@...eaurora.org>,
        "subhashj@...eaurora.org" <subhashj@...eaurora.org>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "vivek.gautam@...eaurora.org" <vivek.gautam@...eaurora.org>,
        "rnayak@...eaurora.org" <rnayak@...eaurora.org>,
        "vinholikatti@...il.com" <vinholikatti@...il.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "evgreen@...omium.org" <evgreen@...omium.org>,
        Bart Van Assche <Bart.VanAssche@....com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V1 3/3] scsi: ufs: Add sysfs support for ufs provision

On Tue, Jun 05, 2018 at 08:16:50AM +0000, Stanislav Nijnikov wrote:
> Hi Sayali,
> 
> I think that passing an array of values in a string is not proper way
> to work with a sysfs entry. There are binary attributes to do such
> things.

No, don't do that, sysfs is for "one value per file", and binary
attributes are for "hardware value pass-through" type stuff.  Unless
this is "raw" data straight from the hardware, binary does not work, and
neither does a normal sysfs file either.

So this needs to be reworked please.

thanks,

greg k-h