linux-kernel - Re: [PATCH 4/7] atomics: add common header generation files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jun 2018 13:52:36 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Boqun Feng <boqun.feng@...il.com>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCH 4/7] atomics: add common header generation files

On Tue, Jun 05, 2018 at 02:25:37PM +0200, Peter Zijlstra wrote:
> On Tue, May 29, 2018 at 07:07:43PM +0100, Mark Rutland wrote:
> > +++ b/scripts/atomic/atomics.tbl
> > @@ -0,0 +1,41 @@
> > +# name	meta	args...
> > +#
> > +# Where meta contains a string of variants to generate.
> > +# Upper-case implies _{acquire,release,relaxed} variants.
> > +# Valid meta values are:
> > +# * B/b	- bool: returns bool
> > +# * v	- void: returns void
> > +# * I/i	- int: returns base type
> > +# * R	- return: returns base type (has _return variants)
> > +# * F/f	- fetch: returns base type (has fetch_ variants)
> > +# * l	- load: returns base type (has _acquire order variant)
> > +# * s	- store: returns void (has _release order variant)
> > +#
> > +# Where args contains list of type[:name], where type is:
> > +# * cv	- const pointer to atomic base type (atomic_t/atomic64_t/atomic_long_t)
> > +# * v	- pointer to atomic base type (atomic_t/atomic64_t/atomic_long_t)
> > +# * i	- base type (int/s64/long)
> > +# * I	- pointer to base type (int/s64/long)
> 
> I thought we agreed to make that 'p' instead of 'I'.

Whoops; I'd left that as a cleanup and never folded it in.

Fixed up now.

Thanks,
Mark