linux-kernel - Re: [PATCH v2 12/21] drm: i2c: ch7006: use match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jun 2018 16:21:03 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Yisheng Xie <xieyisheng1@...wei.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 12/21] drm: i2c: ch7006: use match_string() helper

On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie <xieyisheng1@...wei.com> wrote:
> match_string() returns the index of an array for a matching string,
> which can be used instead of open coded variant.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Cc: David Airlie <airlied@...ux.ie>
> Cc: Yisheng Xie <xieyisheng1@...wei.com>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> Cc: Arvind Yadav <arvind.yadav.cs@...il.com>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> ---
> v2:
>  - handle err case before normal case.
>
>  drivers/gpu/drm/i2c/ch7006_drv.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
> index 544a8a2..9eefdfe 100644
> --- a/drivers/gpu/drm/i2c/ch7006_drv.c
> +++ b/drivers/gpu/drm/i2c/ch7006_drv.c
> @@ -464,16 +464,13 @@ static int ch7006_encoder_init(struct i2c_client *client,
>         priv->chip_version = ch7006_read(client, CH7006_VERSION_ID);
>
>         if (ch7006_tv_norm) {
> -               for (i = 0; i < NUM_TV_NORMS; i++) {
> -                       if (!strcmp(ch7006_tv_norm_names[i], ch7006_tv_norm)) {
> -                               priv->norm = i;
> -                               break;
> -                       }
> -               }
> -
> -               if (i == NUM_TV_NORMS)
> +               i = match_string(ch7006_tv_norm_names,
> +                                NUM_TV_NORMS, ch7006_tv_norm);
> +               if (i < 0)
>                         ch7006_err(client, "Invalid TV norm setting \"%s\".\n",
>                                    ch7006_tv_norm);
> +               else
> +                       priv->norm = i;
>         }
>
>         if (ch7006_scale >= 0 && ch7006_scale <= 2)
> --
> 1.7.12.4
>



-- 
With Best Regards,
Andy Shevchenko