linux-kernel - Re: [PATCH v7 1/5] drm/rockchip: add transfer function for cdn-dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Jun 2018 15:42:11 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Lin Huang <hl@...k-chips.com>
Cc:     seanpaul@...omium.org, airlied@...ux.ie, zyw@...k-chips.com,
        kishon@...com, dianders@...omium.org, briannorris@...omium.org,
        linux-rockchip@...ts.infradead.org, daniel.vetter@...el.com,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        eballetbo@...il.com, robh+dt@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v7 1/5] drm/rockchip: add transfer function for cdn-dp

Hi,

Am Mittwoch, 23. Mai 2018, 09:42:29 CEST schrieb Lin Huang:
> From: Chris Zhong <zyw@...k-chips.com>
> 
> We may support training outside firmware, so we need support
> dpcd read/write to get the message or do some setting with
> display.
> 
> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
> Signed-off-by: Lin Huang <hl@...k-chips.com>
> Reviewed-by: Sean Paul <seanpaul@...omium.org>
> Reviewed-by: Enric Balletbo <enric.balletbo@...labora.com>

> @@ -1030,6 +1064,13 @@ static int cdn_dp_bind(struct device *dev, struct
> device *master, void *data) dp->active = false;
>  	dp->active_port = -1;
>  	dp->fw_loaded = false;
> +	dp->aux.name = "DP-AUX";
> +	dp->aux.transfer = cdn_dp_aux_transfer;
> +	dp->aux.dev = dev;
> +
> +	ret = drm_dp_aux_register(&dp->aux);
> +	if (ret)
> +		return ret;

this is missing matching drm_dp_aux_unregister calls both in the error path as 
well as in the unbind callback.

With the code as is, the kernel gives warnings about it trying to initialize 
an already initialized object ... in cases like probe-deferrals.


Heiko