linux-kernel - Re: [PATCH] coresight: include vmalloc.h for vmap/vunmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Jun 2018 10:06:37 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] coresight: include vmalloc.h for vmap/vunmap

On 5 June 2018 at 05:48, Arnd Bergmann <arnd@...db.de> wrote:
> The newly introduced code fails to build in some configurations
> unless we include the right headers:
>
> drivers/hwtracing/coresight/coresight-tmc-etr.c: In function 'tmc_free_table_pages':
> drivers/hwtracing/coresight/coresight-tmc-etr.c:206:3: error: implicit declaration of function 'vunmap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration]
>
> Fixes: 79613ae8715a ("coresight: Add generic TMC sg table framework")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index 6164eed0b5fe..3556d9a849e9 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -8,6 +8,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/iommu.h>
>  #include <linux/slab.h>
> +#include <linux/vmalloc.h>
>  #include "coresight-priv.h"
>  #include "coresight-tmc.h"
>

Thank you for that - I have picked it up for 4.18-rc1.

Mathieu

> --
> 2.9.0
>