linux-kernel - Re: [PATCH V3 02/17] kallsyms, x86: Export addresses of syscall trampolines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 11:02:08 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>, Jiri Olsa <jolsa@...hat.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH V3 02/17] kallsyms, x86: Export addresses of syscall
 trampolines

On 05/06/18 19:00, Andi Kleen wrote:
>> +#ifdef CONFIG_X86_64
>> +int arch_get_kallsym(unsigned int symnum, unsigned long *value, char *type,
>> +		     char *name)
>> +{
>> +	unsigned int cpu, ncpu;
>> +
>> +	if (symnum >= num_possible_cpus())
>> +		return -EINVAL;
>> +
>> +	for (cpu = cpumask_first(cpu_possible_mask), ncpu = 0;
>> +	     cpu < num_possible_cpus() && ncpu < symnum;
>> +	     cpu = cpumask_next(cpu, cpu_possible_mask), ncpu++)
>> +		;
> 
> That is max_t(unsigned, cpumask_last(cpu_possible_mask), symnum)

I think it should be:

-	     cpu < num_possible_cpus() && ncpu < symnum;
+	     ncpu < symnum;

Alex?

> 
> Rest and other kernel patches look good to me
> 
> Acked-by: Andi Kleen <ak@...ux.intel.com>
> 
> -Andi
>