linux-kernel - Re: [PATCH v2 1/2] compiler-gcc.h: add gnu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 10:05:45 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        akpm@...ux-foundation.org, ard.biesheuvel@...aro.org,
        aryabinin@...tuozzo.com, akataria@...are.com,
        boris.ostrovsky@...cle.com, brijesh.singh@....com,
        caoj.fnst@...fujitsu.com, gregkh@...uxfoundation.org,
        hpa@...or.com, jan.kiszka@...mens.com,
        jarkko.sakkinen@...ux.intel.com, jgross@...e.com,
        jpoimboe@...hat.com, kirill.shutemov@...ux.intel.com,
        mingo@...hat.com, mjg59@...gle.com, mka@...omium.org,
        pombredanne@...b.com, rostedt@...dmis.org, tglx@...utronix.de,
        thomas.lendacky@....com, tweek@...gle.com,
        linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, virtualization@...ts.linux-foundation.org,
        astrachan@...gle.com, manojgupta@...gle.com, ghackmann@...gle.com,
        tstellar@...hat.com, keescook@...gle.com,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        linux-kbuild@...r.kernel.org, geert@...ux-m68k.org,
        will.deacon@....com, mawilcox@...rosoft.com,
        Arnd Bergmann <arnd@...db.de>, rientjes@...gle.com
Subject: Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

Hi,

when discovering 'gnu_inline', I found ...

$ git grep -w  __FORTIFY_INLINE
include/linux/string.h:#define __FORTIFY_INLINE extern __always_inline
__attribute__((gnu_inline))
include/linux/string.h:__FORTIFY_INLINE char *strncpy(char *p, const
char *q, __kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE char *strcat(char *p, const char *q)
include/linux/string.h:__FORTIFY_INLINE __kernel_size_t strlen(const char *p)
include/linux/string.h:__FORTIFY_INLINE __kernel_size_t strnlen(const
char *p, __kernel_size_t maxlen)
include/linux/string.h:__FORTIFY_INLINE size_t strlcpy(char *p, const
char *q, size_t size)
include/linux/string.h:__FORTIFY_INLINE char *strncat(char *p, const
char *q, __kernel_size_t count)
include/linux/string.h:__FORTIFY_INLINE void *memset(void *p, int c,
__kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE void *memcpy(void *p, const
void *q, __kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE void *memmove(void *p, const
void *q, __kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE void *memscan(void *p, int c,
__kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE int memcmp(const void *p,
const void *q, __kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE void *memchr(const void *p,
int c, __kernel_size_t size)
include/linux/string.h:__FORTIFY_INLINE void *memchr_inv(const void
*p, int c, size_t size)
include/linux/string.h:__FORTIFY_INLINE void *kmemdup(const void *p,
size_t size, gfp_t gfp)
include/linux/string.h:__FORTIFY_INLINE char *strcpy(char *p, const char *q)

After the inline changes suggested by Joe this can be adapted?

Beyond this, a general question: Can someone explain why all these
inline defines are in compiler-gcc.h (as there exists compiler.h and
compiler-clang.h)?

Thanks.

Regards,
- Sedat -