linux-kernel - Re: [PATCH] ASoC: ak5558: make two structures static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 10:24:01 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "perex@...ex.cz" <perex@...ex.cz>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] ASoC: ak5558: make two structures static

On Mi, 2018-06-06 at 10:57 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The structure ak5558_pm and soc_codec_dev_ak5558 are local to the
> source and do not need to be in global scope, so make them static.
> Also make soc_codec_dev_ak5558 static.
> 
> Cleans up sparse warnings:
> warning: symbol 'ak5558_pm' was not declared. Should it be static?
> warning: symbol 'soc_codec_dev_ak5558' was not declared. Should it be
> static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Daniel Baluta <daniel.baluta@....com>