linux-kernel - unnecessary tests?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 21:41:53 +0900 (JST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     mchehab@...nel.org, hans.verkuil@...co.com
cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: unnecessary tests?

In the file drivers/media/tuners/mxl5005s.c, the function MXL_BlockInit
contains:

       status += MXL_ControlWrite(fe,
               RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
       status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);

Could the second arguments just be 1 and 0, respectively?  It's true that
the preceeding call contains state->Mode, but in a more useful way, so
perhaps it could be useful for uniformity?

thanks,
julia