linux-kernel - Re: [PATCH] x86/iommu: Fix a typo in a macro parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 06 Jun 2018 23:03:02 +0900 (JST)
From:   Masatake YAMATO <yamato@...hat.com>
To:     tglx@...utronix.de
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, joro@...tes.org
Subject: Re: [PATCH] x86/iommu: Fix a typo in a macro parameter

On Wed, 6 Jun 2018 14:41:57 +0200 (CEST), Thomas Gleixner <tglx@...utronix.de> wrote:
> On Wed, 6 Jun 2018, Thomas Gleixner wrote:
>> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>> > On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@...utronix.de> wrote:
>> > > On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>> > > 
>> > > Can you please explain why 0 is the wrong value.
>> > 
>> > I don't know such constants, 0 and 1.
>> > 
>> > What I change is just the name of macro parameter as 
>> > 
>> >      s/detect/_detect/
>> 
>> OOps. Misread the patch. Sorry.
> 
> But the fix is pretty pointless. IOMMU_INIT_POST_FINISH() is completely
> unused and should just be removed.

Oh, I see. Thank you for taking your time.

Masatake YAMATO

> Thanks,
> 
> 	tglx