linux-kernel - Re: [RFC/PATCH] Input: make input_report_slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 16:45:43 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Henrik Rydberg <rydberg@...math.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [RFC/PATCH] Input: make input_report_slot_state() return boolean

On Tue, Jun 5, 2018 at 7:16 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> Let's make input_report_slot_state() return boolean representing whether
> the contact is active or not. This will allow writing code like:
>
>         if (input_mt_report_slot_state(input, obj->mt_tool,
>                                         obj->type != RMI_2D_OBJECT_NONE) {
>
>                 input_event(sensor->input, EV_ABS, ABS_MT_POSITION_X, obj->x);
>                 input_event(sensor->input, EV_ABS, ABS_MT_POSITION_Y, obj->y);
>                 ...
>         }
>
> instead of:
>
>         input_mt_report_slot_state(input, obj->mt_tool,
>                                    obj->type != RMI_2D_OBJECT_NONE);
>         if (obj->type != RMI_2D_OBJECT_NONE) {
>                 input_event(sensor->input, EV_ABS, ABS_MT_POSITION_X, obj->x);
>                 input_event(sensor->input, EV_ABS, ABS_MT_POSITION_Y, obj->y);
>                 ...
>         }
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---

Looks good to me as well.

In case you still need it:
Acked-by: Benjamin Tissoires <benjamin.tissoires@...aht.com>

Cheers,
Benjamin