linux-kernel - Re: [PATCH v3] kbuild: check for pkg-config on make {menu,n,g.x}config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Jun 2018 17:41:51 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Bjørn Forsman <bjorn.forsman@...il.com>,
        Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH v3] kbuild: check for pkg-config on make
 {menu,n,g.x}config

On 06/04/2018 11:53 PM, Masahiro Yamada wrote:
> Hi Randy,
> 
> 
> 2018-06-04 11:59 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Each of 'make {menu,n,g,x}config' uses (needs) pkg-config to make sure
>> that other required files are present and to determine build flags
>> settings, but none of these check that pkg-config itself is present.
>> Add a check for all 4 of these targets and update
>> Documentation/process/changes.rst to mention 'pkg-config'.
>>
>> Fixes kernel bugzilla #77511:
>> https://bugzilla.kernel.org/show_bug.cgi?id=77511
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Bjørn Forsman <bjorn.forsman@...il.com>
>> ---
>> Strictly speaking, pkg-config is not required if someone is only
>> using 'make {menu,n}config' since there are fallbacks for those
>> two targets.
>>


OK, I made your suggested changes and will test it later and then resend it.

thanks,
-- 
~Randy