linux-kernel - Re: [PATCH V4 1/3] kallsyms: Simplify update_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 16:47:19 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>, Jiri Olsa <jolsa@...hat.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH V4 1/3] kallsyms: Simplify update_iter_mod()

Em Wed, Jun 06, 2018 at 03:13:00PM -0400, Steven Rostedt escreveu:
> On Wed, 6 Jun 2018 15:59:14 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> > Em Wed, Jun 06, 2018 at 02:37:27PM -0400, Steven Rostedt escreveu:
> > > On Wed, 6 Jun 2018 15:13:02 +0200
> > > Peter Zijlstra <peterz@...radead.org> wrote:
> > >   
> > > > On Wed, Jun 06, 2018 at 03:54:09PM +0300, Adrian Hunter wrote:  
> > > > > The logic in update_iter_mod() is overcomplicated and gets worse every time
> > > > > another get_ksymbol_* function is added.
> > > > > 
> > > > > In preparation for adding another get_ksymbol_* function, simplify logic in
> > > > > update_iter_mod().
> > > > > 
> > > > > Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> > > > > Acked-by: Andi Kleen <ak@...ux.intel.com>    
> > > > 
> > > > Both Daniel and Steven touched this function last year, let's also Cc
> > > > them.  
> > > 
> > > Thanks for Ccing me. I tested the patch to make sure my changes still
> > > work and they do:
> > > 
> > > Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>  
> > 
> > Since you said you tested the patch, may I replace the Acked-by with the
> > stronger Tested-by?
> 
> Well, I only tested it against the changes I made earlier. I didn't do
> any other testing, which is why I'm reluctant to say "tested by".
> 
> Perhaps it can be:
> 
> Tested-by: (ftrace changes only) Steven Rostedt (VMware) <rostedt@...dmis.org>

I think that brings more useful information to the log, so should be
useful.

- Arnaldo