linux-kernel - RE: [PATCH] HV: Fix definition of struct hv_vp_assist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 22:41:20 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Tianyu Lan <Tianyu.Lan@...rosoft.com>,
        Allen Marshall <Allen.Marshall@...rosoft.com>
CC:     Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        Alexander Grest <Alexander.Grest@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] HV: Fix definition of struct hv_vp_assist_page.

+Allen

> -----Original Message-----
> From: Thomas Gleixner <tglx@...utronix.de>
> Sent: Wednesday, June 6, 2018 3:18 AM
> To: Tianyu Lan <Tianyu.Lan@...rosoft.com>
> Cc: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; Stephen Hemminger
> <sthemmin@...rosoft.com>; mingo@...hat.com; hpa@...or.com;
> x86@...nel.org; vkuznets@...hat.com; Alexander Grest
> <Alexander.Grest@...rosoft.com>; devel@...uxdriverproject.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH] HV: Fix definition of struct hv_vp_assist_page.
> 
> On Mon, 21 May 2018, Tianyu Lan wrote:
> 
> KY ????

I am looking at the published Hyper-V Top Level Functional Spec now; will get back shortly.
> 
> > The struct hv_vp_assist_page was defined incorrectly.
> > The "vtl_control" should be u64[3], "nested_enlightenments_control"
> > should be a u64 and there is 7 reserved bytes following
> "enlighten_vmentry".
> > This patch is to fix it.
> >
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@...rosoft.com>
> > ---
> >  arch/x86/include/asm/hyperv-tlfs.h | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/hyperv-tlfs.h
> b/arch/x86/include/asm/hyperv-tlfs.h
> > index f7be6d03a310..fae0a5431cdd 100644
> > --- a/arch/x86/include/asm/hyperv-tlfs.h
> > +++ b/arch/x86/include/asm/hyperv-tlfs.h
> > @@ -496,10 +496,11 @@ struct hv_timer_message_payload {
> >  /* Define virtual processor assist page structure. */
> >  struct hv_vp_assist_page {
> >  	__u32 apic_assist;
> > -	__u32 reserved;
> > -	__u64 vtl_control[2];
> > -	__u64 nested_enlightenments_control[2];
> > -	__u32 enlighten_vmentry;
> > +	__u32 reserved1;
> > +	__u64 vtl_control[3];
> > +	__u64 nested_enlightenments_control;
> > +	__u8 enlighten_vmentry;
> > +	__u8 reserved2[7];
> >  	__u64 current_nested_vmcs;
> >  };
> >
> > --
> > 2.14.3
> >