linux-kernel - Re: [PATCH 2/4] Staging:rtl8192e Fix Comparison to False is error prone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Jun 2018 14:05:46 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Janani Sankara Babu <jananis37@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        keescook@...omium.org, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org, Rene.Hickersberger@....at,
        davem@...emloft.net
Subject: Re: [PATCH 2/4] Staging:rtl8192e Fix Comparison to False is error
 prone

On Fri, Jun 08, 2018 at 12:33:56AM -0400, Janani Sankara Babu wrote:
> This patch removes comparison to False(ie. bool) in the code
> 
> Signed-off-by: Janani Sankara Babu <jananis37@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 3c7ba33..ccd898a 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> 
>  	RT_TRACE(COMP_DBG, "====>rx ADDBAREQ from : %pM\n", dst);
>  	if (ieee->current_network.qos_data.active == 0  ||

Is .active the number of active or is it a boolean?  If it's boolean
then it should be changed to !ieee->current_network.qos_data.active
as well.

Keep your eyes open for stuff like this when you're doing checkpatch
fixes.

> -	    (ieee->pHTInfo->bCurrentHTSupport == false) ||
> +	    !(ieee->pHTInfo->bCurrentHTSupport) ||

Remove the parenthesis.

Same throughout.

regards,
dan carpenter